-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Add link to associated ticket #1565
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1565 +/- ##
=======================================
Coverage 39.41% 39.41%
=======================================
Files 146 146
Lines 4775 4775
Branches 1138 1138
=======================================
Hits 1882 1882
Misses 2879 2879
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only blocking item is the link text used. The other comments are strong suggestions.
client/src/app/pages/migration-waves/components/ticket-issue.tsx
Outdated
Show resolved
Hide resolved
client/src/app/pages/migration-waves/components/ticket-issue.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link text is the only thing bugging me still. I'm ok with leaving it and seeing if a ticket comes back with "use the jira instance name please" or similar.
The rest of the code LGTM
client/src/app/pages/migration-waves/components/ticket-issue.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: ibolton336 <[email protected]>
Signed-off-by: ibolton336 <[email protected]>
Signed-off-by: ibolton336 <[email protected]>
Resolves https://issues.redhat.com/browse/MTA-701
Resolves https://issues.redhat.com/browse/MTA-1539